Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Nginx to 1.20.1 #7179

Merged
merged 1 commit into from
May 30, 2021
Merged

Upgrade Nginx to 1.20.1 #7179

merged 1 commit into from
May 30, 2021

Conversation

wzshiming
Copy link
Member

@wzshiming wzshiming commented May 28, 2021 •
edited
Loading

What this PR does / why we need it:

Updating NGINX for a DNS Resolver Vulnerability (CVE-2021-23017)
https://www.nginx.com/blog/updating-nginx-dns-resolver-vulnerability-cve-2021-23017/

nginx/nginx@release-1.19.6...release-1.20.1

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #7164

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 28, 2021
@k8s-ci-robot
Copy link
Contributor

@strongjz: The /test command needs one or more targets.
The following commands are available to trigger jobs:

  • /test pull-ingress-nginx-boilerplate
  • /test pull-ingress-nginx-codegen
  • /test pull-ingress-nginx-gofmt
  • /test pull-ingress-nginx-golint
  • /test pull-ingress-nginx-lualint
  • /test pull-ingress-nginx-chart-lint
  • /test pull-ingress-nginx-test-lua
  • /test pull-ingress-nginx-test
  • /test pull-ingress-nginx-e2e-1-16
  • /test pull-ingress-nginx-e2e-1-17
  • /test pull-ingress-nginx-e2e-1-18
  • /test pull-ingress-nginx-e2e-1-19
  • /test pull-ingress-nginx-e2e-helm-chart

Use /test all to run the following jobs:

  • pull-ingress-nginx-boilerplate

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@strongjz
Copy link
Member

/test all

tao12345666333
tao12345666333 reviewed May 28, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2021
@strongjz
Copy link
Member

/lgtm
/assign @ElvinEfendi

@rikatz
Copy link
Contributor

rikatz commented May 30, 2021

/approve

Let's merge this and see what happens with e2e tests next

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz, tao12345666333, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 30, 2021
@k8s-ci-robot k8s-ci-robot merged commit e780c0b into kubernetes:master May 30, 2021
@strongjz strongjz mentioned this pull request May 30, 2021
Merged
@wzshiming wzshiming deleted the upgrade/nginx branch May 31, 2021 02:40
@answer1991 answer1991 mentioned this pull request Jun 1, 2021
Closed
carnei-ro pushed a commit to carnei-ro/ingress-nginx that referenced this pull request Jun 7, 2021
@wzshiming @carnei-ro
Upgrade Nginx to 1.20.1 (kubernetes#7179)
09fb840
qiqizjl pushed a commit to qiqizjl/ingress-nginx that referenced this pull request Jul 7, 2021
@wzshiming @qiqizjl
Upgrade Nginx to 1.20.1 (kubernetes#7179)
42a12c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 left review comments

@aledbf aledbf Awaiting requested review from aledbf

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@ElvinEfendi ElvinEfendi

@strongjz strongjz

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update nginx to mitigate CVE-2021-23017
6 participants
@wzshiming @k8s-ci-robot @strongjz @rikatz @tao12345666333 @ElvinEfendi